Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): use app.baseURL when fetching error page on server #8888

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

tobyfaux
Copy link
Contributor

πŸ”— Linked issue

Resolves nuxt/nuxt#15437.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves nuxt/nuxt#15437 by prepending app.baseURL when fetching the error page during SSR. This is needed because the localFetch method used has no default baseURL value.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 10, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 10, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3c5747b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636cf8567125110008872125

@pi0 pi0 merged commit 3e34a61 into nuxt:main Nov 10, 2022
@pi0
Copy link
Member

pi0 commented Nov 10, 2022

Thanks!

@tobyfaux tobyfaux deleted the fix/ssr-error-page-base-url branch November 10, 2022 20:36
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
danielroe pushed a commit that referenced this pull request Jan 21, 2023
Co-authored-by: Toby Faux <tobyfaux@Tobys-MacBook-Pro.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot render error page during SSR if app.baseURL is configured
3 participants